fix(groups): Group Flush should handle MessageSizeTooLargeError #33585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Added error handling for MessageSizeTooLarge errors in group flush logic to prevent infinite retries on oversized Kafka messages.
- Modified
BatchWritingGroupStoreto properly handle MessageSizeTooLarge errors during group updates, generating ingestion warnings instead of retrying - Enhanced
promiseRetryutility to support non-retriable errors through newnonRetriableErrorTypesparameter - Added test coverage for MessageSizeTooLarge error scenarios in group property updates
- Fixed production issue where large group properties could cause system instability due to continuous retry attempts
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
plugin-server/src/worker/ingestion/groups/batch-writing-group-store.test.ts
Outdated
Show resolved
Hide resolved
| logger.debug('🚫', `failed ${name}, non-retriable error encountered`, { error }) | ||
| return Promise.reject(error) | ||
| } | ||
|
|
||
| logger.debug('🔁', `failed ${name}, retrying`, { error }) | ||
| const nextInterval = Math.min( | ||
| retryIntervalMillis * defaultRetryConfig.BACKOFF_FACTOR, | ||
| defaultRetryConfig.MAX_INTERVAL | ||
| ) | ||
| await new Promise((resolve) => setTimeout(resolve, retryIntervalMillis)) |
There was a problem hiding this comment.
style: Use the sleep utility function defined in utils.ts for consistency instead of raw Promise timeout
Suggested change
| await new Promise((resolve) => setTimeout(resolve, retryIntervalMillis)< 8000 span class="pl-kos">) | |
| await sleep(retryIntervalMillis) |
pl
approved these changes
Jun 16, 2025
Think you may have not posted the comment 😅 |
pl
reviewed
Jun 16, 2025
| ): Promise<T> { | ||
| if (retries <= 0) { | ||
| logger.error('🚨', `Final retry failure for ${name}`, { previousError }) | ||
| return Promise.reject(previousError) | ||
| } | ||
| return fn().catch(async (error) => { | ||
| // Check if error is non-retriable | ||
| if (nonRetriableErrorTypes && nonRetriableErrorTypes.some((ErrorType) => error instanceof ErrorType)) { | ||
| logger.debug('🚫', `failed ${name}, non-retriable error encountered`, { error }) |
There was a problem hiding this comment.
question: wdyt about bumping it to the warn level? Could be useful to see those errors while troubleshooting
Oops, don't know where it went - reposted 😅 |
adamleithp
pushed a commit
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
We had an issue in production, as the flush logic did not handle KafkaMessageTooLarge errors, which are non-transient and should produce an ingestion warning message. This PR fixes this
Changes
Did you write or update any docs for this change?
How did you test this code?