refactor(cleanup): remove legacy funnel correlation endpoints #33596
+11
−10,829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Major cleanup removing all legacy funnel correlation endpoints and related code, including backend implementations, tests, and model mixins. The changes impact multiple areas of the codebase:
- Removed all legacy funnel correlation-related endpoints from
ee/clickhouse/views/ - Deleted core funnel correlation query logic in
ee/clickhouse/queries/funnels/ - Cleaned up funnel correlation constants and filter mixins in
posthog/models/filters/ - Removed deprecated correlation benchmarks and API endpoints in person views
- Cleaned up cohort actor insertion code paths that used legacy correlation
16 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unused legacy endpoints.
Changes
Removes them.
How did you test this code?
CI run