feat(err): add JSONExtract to the rust hogvm #33607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Major refactoring of the HogVM implementation in Rust, adding JSONExtract functionality and changing error handling behavior for unknown globals.
- Added
construct_free_standingfunction inrust/common/hogvm/src/values.rsto create HogValues from JSON without VM heap access - Modified native function system in
rust/common/hogvm/src/context.rsto improve heap allocation handling through the newwalk_emplacingutility - Changed unknown global variable handling in
rust/common/hogvm/src/vm.rsto return Null instead of errors for more flexible runtime behavior - Added JSONExtract to
RUST_HOGVM_STLarray inposthog/models/error_tracking/hogvm_stl.pyfor parsing nested JSON values
9 files reviewed, 6 comments
Edit PR Review Bot Settings | Greptile
daibhin
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes unknown globals be treated as Null's, rather than returning an error.
The easiest way to tell that this does what it's supposed to is by looking at the test programs, for reviewers