fix(alerts): show the interval alert will check #33601
Conversation
There was a problem hiding this comment.
PR Summary
Improved alert UI clarity by explicitly showing the interval an alert will check, addressing user confusion around hourly alerts not checking the last hour on trend insights.
- Added explicit interval display in alert UI to clearly communicate the time period being monitored
- Screenshots show improved interface making alert check intervals more transparent
- Change is focused on UI clarity rather than modifying the underlying alert checking logic
No files reviewed, no comments
Edit PR Review Bot Settings | Greptile
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 2.57 MB ℹ️ View Unchanged
|
| <div> | ||
| and check {alertForm?.config.check_ongoing_interval ? 'current' : 'last'} | ||
| </div> | ||
| <LemonSelect |
There was a problem hiding this comment.
nit: i'd probably use a info-icon instead of a disabled select.
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted: Caution Detected flapping snapshotsThese snapshots have auto-updated more than once since the last human commit:
The flippy-flappies are deadly and must be fixed ASAP. They're productivity killers.
Triggered by this commit. |
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
Users find it confusing that setting alert to run 'hourly' doesn't check the last hour on the trend insight
Changes
Explicitly show the interval alert will check.
Did you write or update any docs for this change?
How did you test this code?
Tested locally