fix(messaging): fix template CRUD, start exporting plain text from EmailTemplater #33634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Updates the email template system to simplify requirements and improve email format support. Major focus on template creation workflow and email content handling.
- Removed mandatory 'from' address requirement in
MessageTemplate.tsxandmessage_templates.pyfor more flexible template creation - Added plain text email content generation in
emailTemplaterLogic.tsxalongside HTML for better email client compatibility - Changed template lifecycle hook from
propsChangedtoafterMountinmessageTemplateLogic.tsfor more reliable template loading - Updated
NEW_TEMPLATEconstant inconstants.tswith proper Microsoft Office and mobile compatibility formatting
5 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
135
to
136
| const htmlData = await new Promise<any>((res) => editor.exportHtml(res)) | ||
| const textData = await new Promise<any>((res) => editor.exportPlainText(res)) |
There was a problem hiding this comment.
style: consider wrapping these Promise calls in Promise.all() to execute them in parallel for better performance
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
mcharawi
approved these changes
Jun 12, 2025
…stHog/posthog into fix/message-template-creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A few things broke with message template CRUD/UX after some nav changes + liquid templating. This should fix all CRUD ops, plus a couple of other things:
Did you write or update any docs for this change?
How did you test this code?
Verified all things message templates end to end locally