fix: Fix virtual properties with PoE #33703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Fixed virtual properties functionality when Persons on Events (PoE) is enabled by adding virtual fields to the PoE table structure.
- Added
$virt_initial_referring_domain_typeand$virt_initial_channel_typevirtual fields to PoE table inhogql/database/database.py - Added parameterized tests in
hogql/database/schema/test/test_persons.pyto verify virtual property behavior across all PoE modes - Improved code clarity by introducing early
poevariable definition for VirtualTable to reduce duplicate casts - Added test coverage specifically for virtual property behavior in trends with PoE enabled
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
rafaeelaudibert
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
Virtual properties didn't work with PoE enabled. This doesn't affect local dev but is used a lot in prod.
Changes
Fix this issue, get PoE properties working
Did you write or update any docs for this change?
How did you test this code?
Added a test