chore(sql-editor): Update the editor copy for limited rows #33740
Conversation
There was a problem hiding this comment.
PR Summary
Updates the SQL editor's data loading text to improve clarity around query result limitations, replacing confusing pagination terminology with more accurate descriptions of row limits.
- Replaced ambiguous 'entries' with 'rows' in
LoadPreviewTextcomponent for more SQL-consistent terminology - Modified text to clarify when results are limited by query constraints rather than pagination
- Enhanced user experience by making query limitations more explicit in the UI
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 2.57 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Much better than before, but in my opinion, if the query is not limited, displaying "Showing N rows" is still quite ambiguous (did the query return N rows or are you just choosing to show me N rows?). Maybe something like "N rows returned" or "Query returned N rows" might be clearer?
|
Yeah I hear you. I think that could be misleading also, "query returned" to me sounds like it's complete. Let's get this in, use it and see how it feels |
Problem
Changes