8000 fix(plugin-server): fix import by jose-sequeira · Pull Request #33756 · PostHog/posthog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(plugin-server): fix import #33756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix(plugin-server): fix import #33756

merged 1 commit into from
Jun 16, 2025

Conversation

jose-sequeira
Copy link
Contributor

Important

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Problem

Latest merge had an import with "~/" that broke the build

Changes

Did you write or update any docs for this change?

How did you test this code?

@jose-sequeira jose-sequeira requested a review from a team June 16, 2025 16:59
Copy link
Contributor
@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed build error by replacing '~/' import path with relative path '../../../' in plugin-server test file when importing MessageSizeTooLarge error type.

  • Modified plugin-server/src/worker/ingestion/groups/batch-writing-group-store.test.ts to use proper relative path instead of tilde (~) import syntax
  • Simple but critical fix to restore build functionality
  • Change aligns with standard Node.js module import practices

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link
Contributor
@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have also just removed the "src" part but this works

@jose-sequeira jose-sequeira enabled auto-merge (squash) June 16, 2025 17:04
@benjackwhite benjackwhite disabled auto-merge June 16, 2025 17:11
@benjackwhite benjackwhite merged commit f0a49e8 into master Jun 16, 2025
100 of 101 checks passed
@benjackwhite benjackwhite deleted the fix-master-build branch June 16, 2025 17:11
Copy link
Member
@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it helps me merge my PR 🤣

adamleithp pushed a commit that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0