fix(propdefs): Avoid posthog_propertydefinition constraint errors on v2 batch write retries #33768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch write retries
There was a problem hiding this comment.
PR Summary
Modified SQL query in property definitions batch processing to prevent constraint violations during retries. The key change addresses database errors by only updating property_type when the existing value is NULL OR different from the new value, avoiding unnecessary updates that could trigger constraint errors.
- Fixes potential DB constraint errors in
posthog_propertydefinitiontable during v2 batch write retries - Modified ON CONFLICT clause to be more selective about updates, preventing redundant operations
- Warning: Possible typo in table name 'propertydefintion' (missing 'i') needs to be verified
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
nickbest-ph
approved these changes
Jun 16, 2025
3 tasks
adamleithp
pushed a commit
that referenced
this pull request
Jun 17, 2025
…v2 batch write retries (#33768)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part two of a series of PRs attempting to address constraint violation DB errors seen in v2 batch write errors, this one targeting the
posthog_propertydefinitiontable.Changes
Don't attempt to update rows on conflict where
property_typein the DB already equals the batch's record to-be-inserted. This should allow retries on partially-written failed batches to avoid constraint errors.Did you write or update any docs for this change?
How did you test this code?
Locally and in CI