feat: Support coupons for Revenue Analytics
#33771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Added support for coupon analytics in Revenue Analytics, enabling filtering and breakdown by both event-specific coupons and initial customer coupons in PostHog.
- Implemented taxonomy support for four new coupon properties:
coupon,coupon_id,initial_coupon, andinitial_coupon_idintaxonomy/taxonomy.py - Enhanced
LemonInputSelectcomponent to support tooltips on dropdown options for better UX when selecting coupon filters - Added coupon-related query support in HogQL by extending
RevenueAnalyticsInvoiceItemViewandRevenueAnalyticsCustomerViewwith proper Stripe invoice data extraction - Fixed critical issue in
new_option_for_filters_and_group_by.mdguide where subquery variable assignment was removed without alternative - Extended RevenueAnalytics schema and insights query runner to handle new coupon grouping and filtering capabilities
13 files reviewed, 5 comments
Edit PR Review Bot Settings | Greptile
products/revenue_analytics/guides/new_option_for_filters_and_group_by.md
Outdated
Show resolved
Hide resolved
products/revenue_analytics/backend/hogql_queries/revenue_analytics_insights_query_runner.py
Outdated
Show resolved
Hide resolved
|
Size Change: +318 B (+0.01%) Total Size: 2.57 MB ℹ️ View Unchanged
|
jabahamondes
approved these changes
Jun 16, 2025
📸 UI snapshots have been updated 800016 snapshot changes in total. 0 added, 16 modified, 0 deleted:
Triggered by this commit. |
robbie-c
approved these changes
Jun 17, 2025
This could be achieved with `labelComponent` but it's much easier to achieve with a custom prop
We can now filter/breakdown both by the coupon in a specific revenue event, but also the initial coupon used by a person on their first invoice.
We can make this much simpler by extracting some of the logic to some different methods
This avoids the need to run this twice: dagster AND backend
2baccfa to
afefcfe
Compare
ee8def8 to
3a4b4fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now filter/breakdown both by the coupon in a specific revenue event, but also the initial coupon used by a person on their first invoice.