8000 fix(data-modelling ): Use the correct storage option by Gilbert09 · Pull Request #33824 · PostHog/posthog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(data-modelling ): Use the correct storage option #33824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

Gilbert09
Copy link
Member

Changes

  • Use the correct AWS region name var for data modelling

@Gilbert09 Gilbert09 requested a review from EDsCODE 8000 June 17, 2025 20:34
Copy link
Contributor
@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates the AWS region configuration in data modeling workflows to use the correct environment variable AWS_DEFAULT_REGION in credentials dictionary.

  • Added AWS_DEFAULT_REGION to credentials dict in temporal/data_modeling/run_workflow.py for consistent S3 operations
  • Ensures region configuration consistency across test and production environments

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@Gilbert09 Gilbert09 enabled auto-merge (squash) June 17, 2025 20:41
@Gilbert09 Gilbert09 merged commit e135312 into master Jun 17, 2025
100 checks passed
@Gilbert09 Gilbert09 deleted the tom/workflow-region branch June 17, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0