8000 chore: remove extra quota limiting logs by zlwaterfield · Pull Request #33826 · PostHog/posthog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove extra quota limiting logs #33826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

zlwaterfield
Copy link
Contributor

Important

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changes

These were here for debugging but now they are putting too much load on the system so we are removing.

Did you write or update any docs for this change?

How did you test this code?

@zlwaterfield zlwaterfield self-assigned this Jun 17, 2025
Copy link
Contributor
@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Removes excessive debugging logs from quota limiting system to reduce system load. The change focuses on removing report_quota_limiting_event calls that were tracking organization quota updates and team counts.

  • Removes debug logging that was creating unnecessary load while tracking quota limiting states and organization updates
  • Core quota limiting functionality in ee/billing/quota_limiting.py remains unchanged
  • Change aligns with rule about removing noisy capture calls that are redundant with Prometheus counters

1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Comment on lines 681 to 682
except Exception as e:
capture_exception(e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: consider capturing additional context with the exception to help debug quota limiting failures

Suggested change
except Exception as e:
capture_exception(e)
except Exception as e:
capture_exception(e, extra_context={"org_id": org_id, "report_index": report_index})

@pawel-cebula pawel-cebula enabled auto-merge (squash) June 18, 2025 06:04
@pawel-cebula pawel-cebula merged commit 27c2c66 into master Jun 18, 2025
100 checks passed
@pawel-cebula pawel-cebula deleted the zach/remove-extra-quota-logging branch June 18, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0