feat: server side filters #33836
Open
feat: server side filters #33836
+263
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Migrates feature flag filtering from client-side to server-side on the Persons page, specifically for Type and Status filters, improving handling of paginated results with large feature flag sets.
- Added
relatedFeatureFlagsLogic.test.tswith comprehensive test coverage for server-side filter functionality - Modified filtering logic in
relatedFeatureFlagsLogic.tsto transform local filter states into API-compatible parameters - Keeps
evaluation_reasonsfilter on client-side temporarily, with plans to migrate in a future PR - Ensures filters work across all pages instead of just the currently displayed page, fixing issues for orgs with 100+ feature flags
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be ap
2C61
plied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Server side filters for feature flags on Persons page.
Fixes: #32437
Demo Video: https://www.loom.com/share/0e9fed684a2d444d80a805915bd0a262
Changes
Removed client side filtering for
TypeandStatusfilters for Feature Flags, theevaluation_reasonsis still client side, I will open another PR for moving that to server side as well.Did you write or update any docs for this change?
How did you test this code?
I have added tests and included a loom video that shows working implementation.