8000 chore(minor-query-info): Minor updates to query info display by phixMe · Pull Request #33839 · PostHog/posthog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(minor-query-info): Minor updates to query info display #33839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phixMe
Copy link
Contributor
@phixMe phixMe commented Jun 18, 2025

Important

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Problem

Subset of larger changes to redo the materialization pipeline.

Changes

-[x] Remove noise from UX that isn't obvious along with poor icon choice

How did you test this code?

Visual

@phixMe phixMe requested a review from a team June 18, 2025 05:11
@phixMe phixMe changed the title Minor updates to query info display chore(minor-query-info): Minor updates to query info display Jun 18, 2025
Copy link
Contributor
@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates the QueryInfo component's UI in the data warehouse editor sidebar to reduce visual clutter and improve clarity of the materialization display.

  • Removes redundant materialization status icon, simplifying the status indicators in the info panel
  • Replaces lightbulb and bolt icons with a single target icon for better indication of currently viewed query
  • Part of larger materialization pipeline UX improvements focusing on reducing unnecessary visual elements

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

Size Change: 0 B

Total Size: 2.57 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.57 MB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0