chore: remove legacy plan info #33833
Draft
+0
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Major cleanup removing legacy plan and billing v1 code across the codebase, eliminating outdated feature synchronization mechanisms and license-based plan management.
- Removed
Licensemodel's plan constants (SCALE_PLAN,ENTERPRISE_PLAN) and feature lists inee/models/license.py, shifting away from license-based feature management - Eliminated all
sync_all_organization_available_product_featuresrelated code, including the Django command, scheduled task, and app startup call - Removed
_billing_plan_detailsproperty andupdate_available_product_featuresmethod fromOrganizationmodel, suggesting migration to modern billing service - Cleaned up task imports and definitions in multiple files (
tasks.py,scheduled.py,__init__.py), removing legacy billing v1 code
8 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
217
to
219
| if instance._state.adding: | ||
| instance.update_available_product_features() | ||
| if not is_cloud(): | ||
| instance.plugins_access_level = Organization.PluginsAccessLevel.ROOT |
There was a problem hiding this comment.
style: This function could be simplified to a single line since we're now only checking cloud status: if instance._state.adding and not is_cloud(): instance.plugins_access_level = Organization.PluginsAccessLevel.ROOT
Suggested change
| if instance._state.adding: | |
| instance.update_available_product_features() | |
| if not is_cloud(): | |
| instance.plugins_access_level = Organization.PluginsAccessLevel.ROOT | |
| if instance._state.adding and not is_cloud(): | |
| instance.plugins_access_level = Organization.PluginsAccessLevel.ROOT |
patricio-posthog
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
473B
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Changes
This is all legacy and causing some confusion so looking to remove it. Given we don't use licenses in cloud except for the one to request to billing this won't affect cloud.
I still need to test it on self hosting before merging.
Did you write or update any docs for this change?
How did you test this code?