8000 builder: add centos-10-stream target by Habbie · Pull Request #14473 · PowerDNS/pdns · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

builder: add centos-10-stream target #14473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

builder: add centos-10-stream target #14473

merged 2 commits into from
Jun 6, 2025

Conversation

Habbie
Copy link
Member
@Habbie Habbie commented Jul 16, 2024 •
edited
Loading

Short description

Update: now that all deps are available, this PR has become nice and small and simple. --version output from the three products is identical to the EL9 build. Rémi noticed eBPF missing in dnsdist, but that's true for EL9 too and he'll fix that separately.

I will test this on aarch64 before removing the Draft status.

this is hacked up instead of done nicely.
Once EPEL10 becomes available, we can re-enable sodium, re2, etc. and do this nicely, and then start building it periodically to prepare us for RHEL10 (next year I think)

only tested for dnsdist

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the common-helpneeded milestone Jul 16, 2024
@coveralls
Copy link
coveralls commented Jul 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 15461819516

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 61 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.01%) to 63.667%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.8%
pdns/validate.cc 1 68.19%
pdns/backends/gsql/gsqlbackend.hh 2 97.77%
pdns/misc.cc 2 61.77%
pdns/recursordist/aggressive_nsec.cc 2 66.02%
pdns/recursordist/sortlist.cc 2 72.94%
pdns/misc.hh 3 83.68%
pdns/recursordist/pdns_recursor.cc 4 72.35%
pdns/recursordist/syncres.cc 5 80.07%
pdns/signingpipe.cc 5 85.52%
Totals Coverage Status
Change from base Build 15453722165: -0.01%
Covered Lines: 130619
Relevant Lines: 170266
💛 - Coveralls

@Habbie
Copy link
Member Author
Habbie commented Aug 30, 2024

With EPEL10 now available (but not yet complete), this has dnsdist, recursor, auth, minus geoipbackend and ixfrdist (because yaml-cpp), normal lua instead of luajit (should become available soon), and I took out h2o just because I did not feel like debugging it it if it wouldn't work.

@Habbie
Copy link
Member Author
Habbie commented Oct 18, 2024

also tested against re2-20240702-3 now (which is an upcoming ABI-incompatible version bump in EPEL10)

@Habbie Habbie force-pushed the centos-10-stream branch from 7b3fcaf to 3929a7b Compare May 15, 2025 09:11
@Habbie Habbie changed the title do not merge: centos 10 stream support in builder builder: add centos-10-stream target May 15, 2025
@Habbie
Copy link
Member Author
Habbie commented May 15, 2025

Update: original post updated.

@Habbie Habbie force-pushed the centos-10-stream branch from 3929a7b to c18c6d3 Compare May 15, 2025 14:00
@Habbie
Copy link
Member Author
Habbie commented May 16, 2025 •
edited
Loading

Added a commit to enable XSK where possible. Result: (whitespace inserted for easy comparison of the lists)

arm64

el8 : Enabled features: cdb dns-over-quic dns-over-http3 dns-over-tls(gnutls openssl) dns-over-https(nghttp2) dnscrypt ebpf fstrm ipcipher libedit libsodium lmdb protobuf re2 recvmmsg/sendmmsg snmp systemd
el9 : Enabled features: AF_XDP cdb dns-over-quic dns-over-http3 dns-over-tls(gnutls openssl) dns-over-https(nghttp2) dnscrypt ebpf fstrm ipcipher libedit libsodium lmdb protobuf re2 recvmmsg/sendmmsg snmp systemd
c10s: Enabled features: AF_XDP cdb dns-over-quic dns-over-http3 dns-over-tls(gnutls openssl) dns-over-https(nghttp2) dnscrypt ebpf fstrm ipcipher libedit libsodium lmdb protobuf re2 recvmmsg/sendmmsg snmp systemd

amd64

el8 : Enabled features: AF_XDP cdb dns-over-quic dns-over-http3 dns-over-tls(gnutls openssl) dns-over-https(nghttp2) dnscrypt ebpf fstrm ipcipher libedit libsodium lmdb protobuf re2 recvmmsg/sendmmsg snmp systemd
el9 : Enabled features: AF_XDP cdb dns-over-quic dns-over-http3 dns-over-tls(gnutls openssl) dns-over-https(nghttp2) dnscrypt ebpf fstrm ipcipher libedit libsodium lmdb protobuf re2 recvmmsg/sendmmsg snmp systemd
c10s: Enabled featu 8000 res: AF_XDP cdb dns-over-quic dns-over-http3 dns-over-tls(gnutls openssl) dns-over-https(nghttp2) dnscrypt ebpf fstrm ipcipher libedit libsodium lmdb protobuf re2 recvmmsg/sendmmsg snmp systemd

@Habbie Habbie marked this pull request as ready for review May 16, 2025 12:09
ekohl
ekohl reviewed May 16, 2025
View reviewed changes
builder-support/dockerfiles/Dockerfile.target.centos-10-stream

RUN touch /var/lib/rpm/* && dnf install -y epel-release && \
dnf install -y 'dnf-command(config-manager)' && \
dnf config-manager --set-enabled crb
Copy link
Contributor
@ekohl ekohl May 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just learned there's /usr/bin/crb enable as a helper to enable CRB and I think that also works on other EL10-derivatives. It was added in https://src.fedoraproject.org/rpms/epel-release/c/36d5cef26975363fae2dc4704d1cf4d15dc1b315?branch=epel10.

Right now it doesn't make sense but if you'd reuse the same code on a RHEL build it may help:

Suggested change
dnf config-manager --set-enabled crb
/usr/bin/crb enable

@Habbie Habbie force-pushed the centos-10-stream branch from b68d156 to a24a941 Compare June 5, 2025 08:06
@Habbie Habbie merged commit 80c5dd8 into PowerDNS:master Jun 6, 2025
87 checks passed
@Habbie Habbie deleted the centos-10-stream branch June 6, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
common-helpneeded
Development

Successfully merging this pull request may close these issues.
4 participants
@Habbie @coveralls @ekohl @rgacogne
0