8000 Try harder matching command names in pdnsutil by miodvallat · Pull Request #15607 · PowerDNS/pdns · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Try harder matching command names in pdnsutil #15607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Try harder matching command names in pdnsutil #15607

merged 1 commit into from
Jun 5, 2025

Conversation

miodvallat
Copy link
Contributor

Short description

A part of @Habbie's evil plans is to make pdnsutil have a dashless syntax, writing pdnsutil object action arguments, where "object" is a noun and "action" is a verb.

This change attempts to recognize "object-action" and "object action" and rewrites them as "action-object" which is the current naming scheme for pdnsutil commands.

(this is just testing the waters here, and also confirming that I got @Habbie's intentions right)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link
coveralls commented May 28, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15298384484

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.02%) to 63.72%
Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-crypto.cc 1 76.01%
modules/lmdbbackend/lmdbbackend.cc 2 74.7%
pdns/rcpgenerator.cc 2 90.82%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/dnsdistdist/dnsdist-carbon.cc 3 61.8%
pdns/packethandler.cc 3 72.78%
pdns/recursordist/rec-main.cc 3 62.14%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/recursordist/syncres.cc 3 80.21%
pdns/shuffle.cc 4 53.93%
Totals Coverage Status
Change from base Build 15271100803: 0.02%
Covered Lines: 130702
Relevant Lines: 170263
💛 - Coveralls

@miodvallat
Try harder matching command names in pdnsutil.
af8bf6d 
We would like to eventually move towards a consistent naming of the pdnsutil
commands, in the form:
  pdnsutil <object (a noun)> <action (a verb)> <arguments>
with no dash between the object and the action.

However the existing commands are currently in the form action-object.
This change attempts to recognize both "object-action" and "object action"
and rewrites them as "action-object" to match the current command set, as
a first step.
Habbie
Habbie approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member
@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

@Habbie Habbie merged commit a0ffbde into PowerDNS:master Jun 5, 2025
87 checks passed
@miodvallat miodvallat deleted the too_much_sugar branch June 7, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Habbie Habbie Habbie approved these changes

Assignees
No one assigned
Labels
auth tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miodvallat @coveralls @Habbie
0