10000 rec-5.0.x: backport 14565 - gh actions - coveralls: avoid CI failure by setting fail-on-error: false by romeroalx · Pull Request #15623 · PowerDNS/pdns · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

rec-5.0.x: backport 14565 - gh actions - coveralls: avoid CI failure by setting fail-on-error: false #15623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

rec-5.0.x: backport 14565 - gh actions - coveralls: avoid CI failure by setting fail-on-error: false #15623

merged 1 commit into from
Jun 3, 2025

Conversation

romeroalx
Copy link
Member

Short description

Backport of #14565 to rec-5.0.x.

Avoid CI failures related to Coveralls when upload fails due to any errors.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@romeroalx romeroalx requested a review from omoerbeek June 3, 2025 13:27
@omoerbeek omoerbeek merged commit a64f935 into PowerDNS:rel/rec-5.0.x Jun 3, 2025
41 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15418599545

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 51.052%
Files with Coverage Reduction New Missed Lines %
pdns/recursordist/test-syncres_cc1.cc 11 89.2%
Totals Coverage Status
Change from base Build 14726209012: 0.01%
Covered Lines: 44020
Relevant Lines: 73134
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

Assignees
No one assigned
Labels
ci rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romeroalx @coveralls @omoerbeek
0