Sourcery refactored master branch #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powerm4
reviewed
Aug 25, 2023
| print('Current version ' + currentVersion) | ||
| print(f'Current version {currentVersion}') |
There was a problem hiding this comment.
Lines
42-80refactored with the following changes:* Use f-string instead of string concatenation [×15] ([`use-fstring-for-concatenation`](https://docs.sourcery.ai/Reference/Default-Rules/refactorings/use-fstring-for-concatenation/)) * Replace call to format with f-string [×2] ([`use-fstring-for-formatting`](https://docs.sourcery.ai/Reference/Default-Rules/refactorings/use-fstring-for-formatting/))
897abc0 to
8a2da4b
Compare
| print('Current version ' + currentVersion) | ||
| print(f'Current version {currentVersion}') |
There was a problem hiding this comment.
Lines 42-80 refactored with the following changes:
- Use f-string instead of string concatenation [×15] (
use-fstring-for-concatenation) - Replace call to format with f-string [×2] (
use-fstring-for-formatting)
| print("Checking if {} is a jar file".format(filename)) | ||
| print(f"Checking if {filename} is a jar file") |
There was a problem hiding this comment.
Function isJar refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| print(r"Checking if {} matches pattern ^\d+\.\d+\.\d+:".format(message)) | ||
| print(f"Checking if {message} matches pattern ^\d+\.\d+\.\d+:") |
There was a problem hiding this comment.
Function isValidCommitMessage refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-67
to
+83
| print("[!] Error: {} does not exist".format(fileToUploadPath)) | ||
| print(f"[!] Error: {fileToUploadPath} does not exist") | ||
| sys.exit(1) | ||
|
|
||
| if not isJar(fileToUploadPath): | ||
| print("[!] Error: {} is not a jar file!".format(fileToUploadPath)) | ||
| print(f"[!] Error: {fileToUploadPath} is not a jar file!") | ||
| sys.exit(1) | ||
|
|
||
| if not isValidCommitMessage(commitMessage): | ||
| print("[!] Error: {} is not a valid commit message as it does not start with a version".format(fileToUploadPath)) | ||
| print( | ||
| f"[!] Error: {fileToUploadPath} is not a valid commit message as it does not start with a version" | ||
| ) | ||
| sys.exit(1) | ||
|
|
||
|
|
||
| if not args.skip_hash_check: | ||
| if debug: | ||
| print("Reading file {}".format(fileToUploadPath)) | ||
|
|
There was a problem hiding this comment.
Lines 67-104 refactored with the following changes:
- Replace call to format with f-string [×9] (
use-fstring-for-formatting)
| @@ -74,10 +82,12 @@ def update_change_list(message): | |||
| print("Stripping jar") | |||
| subprocess.call(["mvn", "io.github.zlika:reproducible-build-maven-plugin:0.6:strip-jar"]) | |||
| print("Hashing .jar file") | |||
| openedFile = open("./target/ripme-{}-jar-with-dependencies.jar".format(nextVersion), "rb") | |||
| openedFile = open( | |||
There was a problem hiding this comment.
it has not been closed, so consumes more resources than necessary and increases the risk of unexpected side effects. Consider calling open as a context manager to close it automatically. More.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!