8000 Bugfix: Coalesce flow run start times with expected start times by znicholasbrown · Pull Request #17997 · PrefectHQ/prefect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix: Coalesce flow run start times with expected start times #17997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

Bugfix: Coalesce flow run start times with expected start times #17997

merged 3 commits into from
May 7, 2025

Conversation

znicholasbrown
Copy link
Contributor
@znicholasbrown znicholasbrown commented May 7, 2025 •
edited
Loading

This PR fixes an issue where scheduled runs weren't returned when using start_time filters by coalescing start_time and expected_start_time fields. This matches the behavior JS clients are expecting.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #17997 will not alter performance

Comparing 2025-05-07/bugfix/flow-run-start-time-coalesce (945b49d) with main (661452c)

Summary

✅ 2 untouched benchmarks

chrisguidry
chrisguidry approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator
@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I double-checked and the flow_run SA model already has the right index: https://github.com/PrefectHQ/prefect/blob/main/src/prefect/server/database/orm_models.py#L593-L600

cicdw
cicdw approved these changes May 7, 2025
View reviewed changes
Copy link
Member
@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, love seeing you in the python codebase!

@cicdw cicdw merged commit eac7f62 into main May 7, 2025
52 checks passed
@cicdw cicdw deleted the 2025-05-07/bugfix/flow-run-start-time-coalesce branch May 7, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

@cicdw cicdw cicdw approved these changes

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@znicholasbrown @chrisguidry @cicdw
0