8000 Add new aliases tab and remove search_conf feature flag by boherm · Pull Request #1174 · PrestaShop/autoupgrade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add new aliases tab and remove search_conf feature flag #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

Add new aliases tab and remove search_conf feature flag #1174

merged 2 commits into from
Apr 2, 2025

Conversation

boherm
Copy link
Member
@boherm boherm commented Feb 19, 2025
Questions Answers
Description? Add new aliases tab and remove search_conf feature flag.
Related to PrestaShop/PrestaShop#37470.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? ~
Sponsor company PrestaShop SA
How to test? ~

Quetzacoalt91
Quetzacoalt91 previously approved these changes Feb 19, 2025
View reviewed changes
@Quetzacoalt91 Quetzacoalt91 added the enhancement Type: Improvement label Feb 19, 2025
@Quetzacoalt91 Quetzacoalt91 added this to the 7.0.0 milestone Feb 19, 2025
@paulnoelcholot paulnoelcholot self-assigned this Feb 21, 2025
@boherm boherm force-pushed the reorganize-search-aliases branch from 42e2077 to 68487a6 Compare February 25, 2025 14:44
@boherm
Copy link
Member Author
boherm commented Feb 25, 2025

(Rebase and fix conflicts)

M0rgan01
M0rgan01 previously approved these changes Feb 25, 2025
View reviewed changes
@boherm boherm force-pushed the reorganize-search-aliases branch from 68487a6 to d23dc09 Compare March 3, 2025 08:41
@boherm
Copy link
Member Author
boherm commented Mar 3, 2025
8000

(Rebase and fix conflicts another time)

@boherm boherm requested review from Quetzacoalt91 and M0rgan01 March 3, 2025 08:42
Quetzacoalt91
Quetzacoalt91 previously approved these changes Mar 3, 2025
View reviewed changes
M0rgan01
M0rgan01 previously approved these changes Mar 3, 2025
View reviewed changes
@Quetzacoalt91 Quetzacoalt91 removed this from the 7.0.0 milestone Mar 3, 2025
@paulnoelcholot
Copy link

Hello @boherm,

I tested your PR but I found a bug :
image

Can you check that?

Update 8.2.1 to develop on PHP 8.2

@M0rgan01
Copy link
Contributor

@paulnoelcholot What are the test conditions? This feature flag is only present on v9.1.0 (PrestaShop/PrestaShop#38187), here it is only a question of updating to v9.0.0

@M0rgan01
Copy link
Contributor
M0rgan01 commented Mar 13, 2025 •
edited
Loading

Update 8.2.1 to develop

Here we test update to Prestashop 9.0.0 :)

@paulnoelcholot
Copy link

Hello @boherm,

I tested your PR but I don't found the new aliases tab and search_conf feature flag is already here :

PR-2025-03-14_11.09.11.mp4

Update 8.2.1 to 9.0.x

Thanks for your feedback!

@M0rgan01 M0rgan01 dismissed stale reviews from Quetzacoalt91 and themself via 6269946 April 1, 2025 08:30
@M0rgan01 M0rgan01 force-pushed the reorganize-search-aliases branch 2 times, most recently from 6269946 to cf276f1 Compare April 1, 2025 08:35
@M0rgan01 M0rgan01 force-pushed the reorganize-search-aliases branch 5 times, most recently from ece49c3 to fe46b6f Compare April 1, 2025 10:15
@M0rgan01 M0rgan01 force-pushed the reorganize-search-aliases branch from fe46b6f to 128710e Compare April 1, 2025 10:27
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Apr 1, 2025

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@M0rgan01 M0rgan01 added this to the 7.1.0 milestone Apr 1, 2025
@M0rgan01
Copy link
Contributor
M0rgan01 commented Apr 2, 2025

image

Work as expected

@M0rgan01 M0rgan01 merged commit c9a8ace into PrestaShop:dev Apr 2, 2025
63 of 66 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Apr 2, 2025
@ps-jarvis ps-jarvis moved this from Merged to Ready for review in PR Dashboard Apr 2, 2025
@boherm boherm deleted the reorganize-search-aliases branch April 2, 2025 12:46
7EDF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

@M0rgan01 M0rgan01 M0rgan01 left review comments

Assignees

@boherm boherm

@paulnoelcholot paulnoelcholot

Labels
enhancement Type: Improvement QA by dev ✔️
Projects
PR Dashboard
Archived in project
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@boherm @paulnoelcholot @M0rgan01 @Quetzacoalt91 @ps-jarvis
0