8000 feat: add shipment table by PoulainMaxime · Pull Request #1200 · PrestaShop/autoupgrade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add shipment table #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2025
Merged

feat: add shipment table #1200

merged 5 commits into from
May 13, 2025

Conversation

PoulainMaxime
Copy link
Contributor
@PoulainMaxime PoulainMaxime commented Feb 26, 2025 •
edited
Loading
Questions Answers
Description? This pull request works with PrestaShop/PrestaShop#38046.
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #{issue URL here}, Fixes #{another issue URL here}
Sponsor company -
How to test? upgrade a shop to v.9.1.0 version and check if the table is created

@Quetzacoalt91 Quetzacoalt91 added the new feature Type: New feature label Feb 26, 2025
@ga-devfront ga-devfront added the Blocked Status: The issue is blocked by another task label Feb 26, 2025
@PoulainMaxime PoulainMaxime force-pushed the feature/add-shipment-table branch from 104f88b to 7cf54f1 Compare February 27, 2025 09:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Mar 3, 2025
Merged
@Quetzacoalt91 Quetzacoalt91 removed the Blocked Status: The issue is blocked by another task label Mar 4, 2025
Quetzacoalt91
Quetzacoalt91 previously approved these changes Mar 5, 2025
View reviewed changes
@ga-devfront ga-devfront added this to the 7.1.0 milestone Mar 10, 2025
@paulnoelcholot
Copy link

Hello @PoulainMaxime,

Can you you fill the How to test, please?

Thanks for your contribution :)

@PoulainMaxime
Copy link
Contributor Author
PoulainMaxime commented Apr 25, 2025 •
edited
Loading

Hello @PoulainMaxime,

Can you you fill the How to test, please?

Thanks for your contribution :)

Oh, sorry I didn't see your message ... I filled the description to explain how to test this PR :)

@Quetzacoalt91 Quetzacoalt91 removed this from the 7.1.0 milestone May 2, 2025
@PoulainMaxime PoulainMaxime force-pushed the feature/add-shipment-table branch from 4c41148 to 0f3738a Compare May 12, 2025 07:48
Quetzacoalt91
Quetzacoalt91 previously approved these changes May 12, 2025
View reviewed changes
@AureRita AureRita self-assigned this May 12, 2025
AureRita
AureRita reviewed May 12, 2025
View reviewed changes
Copy link
Contributor
@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PoulainMaxime

Thank you for your PR, I tested it and I have this issue on the upgrade part :

image

There are the different error :

var/www/html/pr_autoup/classes/db/DbPDO.php line 151 - PrestaShopException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'COLLATION' at line 18
#0 /var/www/html/pr_autoup/classes/db/Db.php(381): DbPDOCore->_query()
#1 /var/www/html/pr_autoup/classes/db/Db.php(571): DbCore->query()
#2 /var/www/html/pr_autoup/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(489): DbCore->execute()
#3 /var/www/html/pr_autoup/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(358): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runSqlQuery()
#4 /var/www/html/pr_autoup/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(176): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runQuery()
#5 /var/www/html/pr_autoup/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(61): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->updateDatabase()
#6 /var/www/html/pr_autoup/modules/autoupgrade/classes/Task/Runner/ChainedTasks.php(65): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->run()
#7 /var/www/html/pr_autoup/admin-dev/autoupgrade/ajax-upgradetab.php(54): PrestaShop\Module\AutoUpgrade\Task\Runner\ChainedTasks->run()
#8 {main}

Waiting for your feedback about this correction

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@PoulainMaxime
Copy link
Contributor Author

Hi @PoulainMaxime

Thank you for your PR, I tested it and I have this issue on the upgrade part :

image

There are the different error :

var/www/html/pr_autoup/classes/db/DbPDO.php line 151 - PrestaShopException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'COLLATION' at line 18
#0 /var/www/html/pr_autoup/classes/db/Db.php(381): DbPDOCore->_query()
#1 /var/www/html/pr_autoup/classes/db/Db.php(571): DbCore->query()
#2 /var/www/html/pr_autoup/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(489): DbCore->execute()
#3 /var/www/html/pr_autoup/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php(358): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runSqlQuery()
#4 /var/www/html/pr_autoup/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(176): PrestaShop\Module\AutoUpgrade\UpgradeTools\CoreUpgrader\CoreUpgrader->runQuery()
#5 /var/www/html/pr_autoup/modules/autoupgrade/classes/Task/Update/UpdateDatabase.php(61): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->updateDatabase()
#6 /var/www/html/pr_autoup/modules/autoupgrade/classes/Task/Runner/ChainedTasks.php(65): PrestaShop\Module\AutoUpgrade\Task\Update\UpdateDatabase->run()
#7 /var/www/html/pr_autoup/admin-dev/autoupgrade/ajax-upgradetab.php(54): PrestaShop\Module\AutoUpgrade\Task\Runner\ChainedTasks->run()
#8 {main}

Waiting for your feedback about this correction

Hi @AureRita, I fixed the above problem, and everything should work.

AureRita
AureRita approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor
@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PoulainMaxime

Thank you for your PR, I tested it and it seems to works as you can see :

image

image

image

Tested from :
8.0.3 to 8.2.1
8.2.1 to 9.1.0
8.0.3 to 9.1.0

Because the PR seems to works as expected, It's QA ✔️

Thank you
8000

@Quetzacoalt91 Quetzacoalt91 added this to the 7.1.0 milestone May 13, 2025
@Quetzacoalt91 Quetzacoalt91 merged commit d3deefa into PrestaShop:dev May 13, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@AureRita AureRita AureRita approved these changes

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 left review comments

Assignees

@PoulainMaxime PoulainMaxime

@AureRita AureRita

Labels
new feature Type: New feature QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@PoulainMaxime @paulnoelcholot @Quetzacoalt91 @M0rgan01 @AureRita @ps-jarvis @ga-devfront
0