[NEW UI] Update notification remind me later #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Questions | Answers |
|---|---|
| Description? | Replace "dismiss" button in update notification dialog to got remind me later with multiple choices (7 days, 30 days, until next release) |
| Type? | improvement / new feature |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| Sponsor company | @PrestaShopCorp |
| How to test? | Check internal ticket |
tblivet
reviewed
Apr 3, 2025
|
Quetzacoalt91
approved these changes
Apr 3, 2025
ingridusta
approved these changes
Apr 3, 2025
There was a problem hiding this comment.
Hello @ga-devfront,
This PR had been tested on a PS v1.7.8.11.
The update modale on the BO is well displayed + the CTA "Remind me later" is also effective. The 3 choices are displayed and working as excepted.
Multiple tests have been done on the DB as :
- Changing the timestamp to be sure that the modale is displayed again or not according to the choice made
- Filling the timestamp with non correct datas (letters, special caracters, blank)
Further tests will be done when the front will be available.
QA approved ✅
Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.