Improve web archive retrieval #1304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6be5f85 to
7af2e9d
Compare
| self::TYPE_ZIP => $zipList, | ||
| self::TYPE_XML => $xmlList, | ||
| ]; | ||
| } |
There was a problem hiding this comment.
Can you please add a unit test for this new function?
There was a problem hiding this comment.
I will do it, of course :)
7af2e9d to
283a4ee
Compare
|
Quetzacoalt91
approved these changes
Apr 10, 2025
ga-devfront
approved these changes
Apr 14, 2025
AureRita
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as you can see :
Capture.video.du.2025-04-15.14-19-40.mp4
Tested from :
8.0.5 to 8.1.2
8.1.2 to 8.2.1
8.0.5 to 8.2.1
Because the PR seems to works as expected, It's QA ✔️
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update:check-new-versionCLI command and the local channel on the web ui.