8000 Disable OPcache on critical steps, revert requirement previously added by M0rgan01 · Pull Request #1327 · PrestaShop/autoupgrade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Disable OPcache on critical steps, revert requirement previously added #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 13, 2025
Merged

Disable OPcache on critical steps, revert requirement previously added #1327

merged 6 commits into from
May 13, 2025

Conversation

M0rgan01
Copy link
Contributor
@M0rgan01 M0rgan01 commented Apr 23, 2025 •
edited
Loading
Questions Answers
Description? Disable OPcache on critical steps, remove requirement assosiated
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#38125
Sponsor company -
How to test? Update and restoration should work correctly, see PrestaShop/PrestaShop#38125 for reproduction

@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Apr 23, 2025
@M0rgan01 M0rgan01 added this to the 7.1.0 milestone Apr 23, 2025
@M0rgan01 M0rgan01 force-pushed the op-cache-remove-requirements branch from 014141f to 97f998d Compare April 23, 2025 14:03
Hlavtox
Hlavtox reviewed Apr 23, 2025
View reviewed changes
@M0rgan01 M0rgan01 force-pushed the op-cache-remove-requirements branch from 97f998d to c750fc5 Compare April 23, 2025 14:12
Quetzacoalt91
Quetzacoalt91 reviewed Apr 23, 2025
View reviewed changes
Quetzacoalt91
Quetzacoalt91 previously approved these changes Apr 24, 2025
View reviewed changes
ga-devfront
ga-devfront previously approved these changes Apr 24, 2025
View reviewed changes
@Quetzacoalt91 Quetzacoalt91 added the enhancement Type: Improvement label Apr 25, 2025
@AureRita AureRita self-assigned this Apr 28, 2025
@M0rgan01 M0rgan01 dismissed stale reviews from ga-devfront and Quetzacoalt91 via 9f78886 April 28, 2025 11:36
@M0rgan01 M0rgan01 force-pushed the op-cache-remove-requirements branch 2 times, most recently from f37f5ea to 3035c01 Compare April 28, 2025 13:15
@M0rgan01 M0rgan01 closed this Apr 28, 2025
@github-project-automation github-project-automation bot moved this from Ready for review to Closed in PR Dashboard Apr 28, 2025
@M0rgan01 M0rgan01 reopened this Apr 28, 2025
@ps-jarvis ps-jarvis moved this from Closed to Ready for review in PR Dashboard Apr 28, 2025
@github-project-automation github-project-automation bot moved this from Ready for review to Reopened in PR Dashboard Apr 28, 2025
Quetzacoalt91
Quetzacoalt91 previously approved these changes Apr 28, 2025
View reviewed changes
@M0rgan01 M0rgan01 force-pushed the op-cache-remove-requirements branch from 3035c01 to 9c6dde0 Compare April 28, 2025 15:16
Quetzacoalt91
Quetzacoalt91 previously approved these changes Apr 28, 2025
View reviewed changes
ga-devfront
ga-devfront previously approved these changes Apr 28, 2025
View reviewed changes
@M0rgan01 M0rgan01 dismissed stale reviews from ga-devfront and Quetzacoalt91 via 495ee35 April 30, 2025 08:25
ga-devfront
ga-devfront previously approved these changes May 7, 2025
View reviewed changes
AureRita
AureRita previously requested changes May 12, 2025
View reviewed changes
Copy link
Contributor
@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M0rgan01

Thank you for your PR, I tested it and :

When I have my OPcache.validate timestamp=0, I get :

image

and when I have my opcache.revalidate freq =100, I get :

image

Waiting for feedback about this issue on update

@Quetzacoalt91 Quetzacoalt91 force-pushed the op-cache-remove-requirements branch from 3e32b3c to 94fc3f7 Compare May 12, 2025 15:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Quetzacoalt91
Quetzacoalt91 approved these changes May 12, 2025
View reviewed changes
Copy link
Member
@Quetzacoalt91 Quetzacoalt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by @M0rgan01

@ga-devfront
Copy link
Contributor

image

AureRita
AureRita approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor
@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M0rgan01

Thank you for your PR, I tested it with each case :

  • opcache disabled
  • op cache enabled and opcache.revalidate_freq = 0 and opcache.validate_timestamps=1
  • op cache enabled and opcache.revalidate_freq = 100
  • op cache enabled and opcache.validate_timestamps=0

And I still have the same result :
image

Tested from :
1.7.8.9 to 8.2.1

Because the PR seems to works as expected, It's QA ✔️

Thank you

@Quetzacoalt91 Quetzacoalt91 merged commit e714508 into PrestaShop:dev May 13, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this from Reopened to Merged in PR Dashboard May 13, 2025
@ps-jarvis ps-jarvis moved this from Merged to Reopened in PR Dashboard May 13, 2025
@Quetzacoalt91 Quetzacoalt91 deleted the op-cache-remove-requirements branch May 13, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hlavtox Hlavtox Hlavtox left review comments

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

@AureRita AureRita AureRita approved these changes

@ga-devfront ga-devfront ga-devfront left review comments

Assignees

@AureRita AureRita

Labels
enhancement Type: Improvement QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@M0rgan01 @ga-devfront @Hlavtox @Quetzacoalt91 @AureRita @ps-jarvis
0