8000 Update minimum compatibility of the theme by kpodemski · Pull Request #411 · PrestaShop/hummingbird · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update minimum compatibility of the theme #411

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2022
Merged

Update minimum compatibility of the theme #411

merged 2 commits into from
Dec 20, 2022

Conversation

kpodemski
Copy link
Contributor
@kpodemski kpodemski commented Dec 19, 2022 •
edited
Loading
Questions Answers
Description? Drop support for 1.7
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? n/a
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

@NeOMakinG
Copy link
Contributor

@kpodemski which feature?

@Hlavtox
Copy link
Contributor
Hlavtox commented Dec 20, 2022

I will go against Krystian here. ;-) I think we should support 8.0 and newer. Because:

  • Why not, if it works.
  • 8.1 should is backwards compatible, the theme could be also.
  • It will allow people to migrate to hummingbird before 8.1 upgrade.
  • It will allow people to start building new themes based on this, which will work with 8.0 also.

However, if a change comes that will just require 8.1, I will bump the compatibility with no regrets.

@kpodemski
Copy link
Contributor Author

@Hlavtox

As a theme developer, you don't put your theme for a sell for PrestaShop 8.0 if an 8.1 is available. It's not only about the theme but also about the modules you use inside.

Anyway, we can go for 8.0, important is to drop 1.7 :-)

@Hlavtox Hlavtox merged commit fe17161 into PrestaShop:develop Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharakPL SharakPL SharakPL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpodemski @NeOMakinG @Hlavtox @SharakPL
0