8000 Fix checkout navigation, fix active button style by Hlavtox · Pull Request #450 · PrestaShop/hummingbird · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix checkout navigation, fix active button style #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

Hlavtox
Copy link
Contributor
@Hlavtox Hlavtox commented Jan 31, 2023
Questions Answers
Description? Please be specific when describing this change. What did you change? Why?
Type? bug fix / improvement / new feature / refactor
BC breaks? yes / no
Deprecations? yes / no
Fixed ticket? Fixes #{issue URL here}, Fixes #{another issue URL here}
Sponsor company Your company or customer's name goes here (if applicable).
How to test? Indicate how to verify that this change works as expected.

This was referenced Jan 31, 2023
Copy link
Contributor
@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks legit, but there's no How to test. At which point should every PR require QA?

@Hlavtox
Copy link
Contributor Author
Hlavtox commented Feb 9, 2023

@kpodemski No QA yet

@kpodemski kpodemski added this to the Beta milestone Feb 9, 2023
@kpodemski kpodemski merged commit f94169b into PrestaShop:develop Feb 9, 2023
@Hlavtox Hlavtox deleted the fix-checkout branch February 9, 2023 11:07
@tajriba
Copy link
tajriba commented Mar 4, 2023

why is _checkout-steps.scss not renamed to _checkout-navigation.scss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0