8000 Fix price slider implementation stripping parameters by Hlavtox · Pull Request #452 · PrestaShop/hummingbird · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix price slider implementation stripping parameters #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix price slider implementation stripping parameters #452

merged 1 commit into from
Mar 6, 2023

Conversation

Hlavtox
Copy link
Contributor
@Hlavtox Hlavtox commented Jan 31, 2023
Questions Answers
Description? Price slider implementation was stripping all other parameters except q. For example, this resulted in breaking filtering on a search page.
Type?
BC breaks?
Deprecations?
Fixed ticket?
Sponsor company
How to test?

@Hlavtox Hlavtox changed the title Fix price slider implementation stripping parameters and breaking filtering Fix price slider implementation stripping parameters Jan 31, 2023
@Hlavtox Hlavtox mentioned this pull request Jan 31, 2023
Open
47 tasks
zuk3975
zuk3975 reviewed Feb 2, 2023
View reviewed changes
zuk3975
zuk3975 reviewed Feb 2, 2023
View reviewed changes
zuk3975
zuk3975 reviewed Feb 2, 2023
View reviewed changes
@Hlavtox
Copy link
Contributor Author
Hlavtox commented Feb 3, 2023

@NeOMakinG my dear, could you fix it for me? 😁🥰

JBLach
JBLach reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor
@JBLach JBLach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hlavtox
I added suggestions that should fix the problem :)

@matthieu-rolland
Copy link
Contributor

thank you @Hlavtox 👍

@matthieu-rolland matthieu-rolland merged commit 5fedf7e into PrestaShop:develop Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuk3975 zuk3975 zuk3975 left review comments

@JBLach JBLach JBLach left review comments

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hlavtox @matthieu-rolland @zuk3975 @JBLach
0