8000 Fix: changing the country creates a new address by NeOMakinG · Pull Request #395 · PrestaShop/hummingbird · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: changing the country creates a new address #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix: changing the country creates a new address #395

merged 1 commit into from
Dec 6, 2022

Conversation

NeOMakinG
Copy link
Contributor
Questions Answers
Description? When changing the country in the form, an ajax call is made, and it needs to include the $id_address.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #30375
How to test? Follow the steps to reproduce in #30375. Notice that the form action URL still contains the address id after changing the country.
Possible impacts? This should not have any other impact than the one described.

@matthieu-rolland
Copy link
Contributor

@NeOMakinG should we reopen the issue ? I'm setting the PR as ready for QA since your how to test filled and the issue was apparently tested

@NeOMakinG
Copy link
Contributor Author

@matthieu-rolland No, we need to original issue to be reproduced, we've to talk with the QA

@nicosomb nicosomb merged commit A509 7a3b29b into PrestaShop:develop Dec 6, 2022
@nicosomb
Copy link
Contributor
nicosomb commented Dec 6, 2022

Thank you @NeOMakinG !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@lartist lartist lartist approved these changes

@0x346e3730 0x346e3730 0x346e3730 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to change country in address
5 participants
@NeOMakinG @matthieu-rolland @nicosomb @lartist @0x346e3730
0