8000 Add new splashes to Pridepack by NormalFery · Pull Request #104 · Pridecraft-Studios/pridepack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add new splashes to Pridepack #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

Conversation

NormalFery
Copy link
Member
@NormalFery NormalFery commented Jun 10, 2025

Self explanatory.

As for what each splash is:

Happy Pride Month 2025
Works on 1.13-1.21.6
Updates for relevant dates or versions

Rebundled Bundles
Reference to the new bundle textures from Issue #98 (PR #99)

Rainbow Chasers!

Chase the Rainbow!

The sky is full of rainbows to explore!

Reference to the Pridepack Update name

water is so gay the harnesses changed

Cauldrons can be used to undye items. this just pokes fun at the fact that the water is so gay that undying the harnesses made them prideful

Done before 1.21.6

We were feature complete before 1.21.6 released! (Hopefully it'll happen for 1.21.7+)

Over 100 issues and PRs on GitHub

As of #100 , Pridepack has had over 100 issues and PRs done

Now configurable with ResPackOps!

Self-explanatory

Works with Packwiz!

I like packwiz. And Pridepack works with it

Why are the paintings floating?

Originally was flying instead of floating, but pretty much just a fun poke at the fact that Pridepack has as of 9.0, 4 different paintings with flying/floating references

June 6th 1994, Day 2546

Reference to the show Code Lyoko - Episode 52 (Season 2 Episode 26) : The Key (you should however watch the previous ones)
Some folks there know about Pridecraft and Pridepack so I just wanted to add the reference to people who know it
The show is not controversial as far as I know - It's just a fun nod to it.

@blryface
Copy link
Member

fery.

you can mention issues by typing #[number]

#1 , #100

@NormalFery
Copy link
Member Author

i know but I just wasn't sure if I should or not since like

it'd appear as mentioned to something like 99% unrelated

@blryface
Copy link
Member

not how that works

@NormalFery
Copy link
Member Author
8000 NormalFery commented Jun 10, 2025

not how that works

image

@blryface
Copy link
Member

that proves my point lol

@blryface
Copy link
Member

nvm I misread

@blryface
Copy link
Member

those are closed issues, it doesn't matter

@NormalFery
Copy link
Member Author

Still I just wanted to stay safe just in case

@NormalFery
Copy link
Member Author

I've changed some things from feedback, any change this could be reviewed for merge? :3

@@ -190,7 +190,7 @@ Go watch the Pridepack trailer!
???
THE END IS NEVER THE END IS NEVER THE END IS NEVER
THE CAKE IS A LIE!
Works on 1.13-1.21.4!
Works on 1.13-1.21.6!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000 I wonder if it's technically the truth if we say b1.3-1.21.6 since Pridepack Legacy adds the beta compat

@@ -270,3 +270,14 @@ Also try QNN!
Also try CRSS!
Also try Modfest!
As seen on BlanketCon 25!
Rebundled Bundles!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every single new splash needs to be put before Line 219

@NormalFery NormalFery requested a review from blryface June 11, 2025 21:23
@NormalFery
Copy link
Member Author

Changed the splashes to be Pridepack compliant (before Line 219)

also I really don't think we can claim that since it's a different file?

@blryface
Copy link
Member

also I really don't think we can claim that since it's a different file?

let's just include terrain.png and whatever else we need to in prod pridepack /s

Copy link
Member
@blryface blryface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blryface
Copy link
Member

oh.

@blryface blryface merged commit be4697d into Pridecraft-Studios:main Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0