8000
Added support for camera selection by DiTheRX · Pull Request #41 · Project-Babble/ProjectBabble · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab o
8000
r window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there, I have just tested your branch and really like this idea.
During my test I found a few small things.
in misc_utils.py
It seems FilterGraph() can only be called once so once a UVC source is selected, it crashes. I simply assigned graph the result of FIlterGraph at the top of the file and removed the assignments from the functions.
in camera_widget.py
On line 267 There is no check for "COM" or "/dev/tty" so when these serial ports are selected, "http://" is appended. Adding these checks allowed me to connect my serial cameras.
Can you please add these changes so it can be merged?
Hey there, I have just tested your branch and really like this idea. During my test I found a few small things.
in misc_utils.py It seems FilterGraph() can only be called once so once a UVC source is selected, it crashes. I simply assigned graph the result of FIlterGraph at the top of the file and removed the assignments from the functions.
in camera_widget.py On line 267 There is no check for "COM" or "/dev/tty" so when these serial ports are selected, "http://" is appended. Adding these checks allowed me to connect my serial cameras.
Can you please add these changes so it can be merged?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.