Implement SUMMON_PROP_FLAG_USE_CREATURE_LEVEL #131
Conversation
|
Maybe by default guardians don't scale level, unlike pets ? It has guardian control type in the properties. |
|
I
The only way to have an ideal fix across the board is to have a perfect understanding of all the various summons, their types and properties, etc. It isn't likely I will have that anytime soon, and so I have to work within the bounds of what logic is already in place, fix what is directly responsible for producing a wrong effect, and not cause a blast radius that breaks other things that are assumed to be working correctly. I don't know if all guardians should not scale or not, but the feature request wants to implement this flag which is assumed to allow the summon to keep its creature level. Just guardians specifically, this line always setting the owners level for all guardians, so needed to be fixed: and likewise for the spell cast that creates the summons, this line was also always setting the owners level: So without breaking or changing the other variations of summons, we check this flag for guardians and if its present we do not set the owner level: The overrideLevel stuff was just added to support profession required summons with the SummonGuardian spell: which funny enough, the code to support engineering summons was here, but the actual engineering summons from a trinket like the dragonling doesn't even use this spell. but this does allow for creating a dog-whistle type item with a profession requirement, and using the profession level as the creature level. If we can get people to to confirm/agree that ALL guardian summons should not scale with owner, then I would be happy to remove the need for the flag alltogether. |
|
Awaiting designer feedback |
|
I took a look through various summons that are guardians and here are my findings: There's a level 44 elite named Myzrael that summons guardians throughout her fight, here they scale to her level, but watching footage of the fight from Classic shows that her summons are level 43, so they do not scale to her level. There is a somewhat famous rare mob in the barrens named Engineer Whirleygig who is a death sentence on Hardcore servers due to the fact that he summons a level 35 Compact Harvest Reaper. Here however, it is scaling to his level. I'll provide fewer details for the rest of these but I was able to verify these with videos or old wowhead comments. Lady Jaina Proudmoore summons level 55-56 Water Elementals, which are below her level. Celebras the Cursed within Maraudon is level 49 and summons level 44 Corrupt Forces of Nature. Captain Kromcrush in Dire Maul is level 61 and summons mobs with a level range that is sometimes below 61. There are various other items players use that should not scale to your level that are in this list as well, I was able to confirm: Dragon's Call, Spiked Collar, Barov Peasant Collar, Training Dummy (and advanced and masterwork), Explosive Sheep, Defender of the Timbermaw, Mechanical Greench, Jewelcrafting stone golems, Book of the Dead/Ancient Cornerstone Grimoire (same spell). I could not confirm every single spell as there are 406 of them, but I was never able to find any guardian (to be clear, Title 2 Summon Property) that scaled to the player's level. Here is something interesting however. I decided to search for any guardians that do contain the flag, and only a few Wrath entries appear, and I decided to investigate these. It appears that Summon Ethereal Worg (56313) DOES scale to your level. As you can see here: https://youtu.be/lU9QLSrwxnY?t=43 and here: https://youtu.be/2sNtjg1U9X4?t=32 the worg is level 79 for the level 79 player and it is level 80 for the level 80 player. I looked at multiple more videos and couldn't find any that counters this claim, except for a video in Cataclysm that showed a level 83 summoning a level 80 wolf, I suspect it couldn't scale beyond its expansion boundaries? The TL;DR is that I believe this flag has the inverse effect on Guardians (Title 2 summons), instead causing them to scale to the summoner's level rather than causing them to not. |
|
Cool I will make the corrections to flip this behavior later tonight or tmw |
|
Very cool thanks. |
property from
#41
Some notes:
The dog whistle summons a lvl 30 hound, but the SummonProperties.dbc
entry is:
61 1 0 2 0 2
The flags column does not contain the flag to disable setting the players level. This will need to be updated:
|= 256
The greench and timbermaw defender and I suspect others use this same SummonProperties entry, so if you want the flag to apply to all of them, that is to not take on the owners level, you need to update this flag.