8000 [RSS] Portal Spawn Fix by Akkadius · Pull Request #1406 · ProjectEQ/projecteqquests · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[RSS] Portal Spawn Fix #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

[RSS] Portal Spawn Fix #1406

merged 1 commit into from
May 16, 2025

Conversation

Akkadius
Copy link
Member

This fixes an issue where RSS portals would stack up when zone state is restored.

Two things -

  • CheckPortal gets ran when the encounter is loaded. The problem with spawning things during encounter registration with no NPC owner attached is that we can't determine anything about zone state being restored at this time. We could potentially add source level fixes for this but for now I've fixed it in the script here.
  • Other issue is that there is a race condition of what NPC's are spawned in what order so sometimes on repop portals don't spawn and sometimes the princesses don't spawn. I've adjusted both King and Queen to do a delayed 1 second spawn routine

@joligario joligario requested a review from fryguy503 May 16, 2025 23:52
@Akkadius Akkadius merged commit 18c9a13 into master May 16, 2025
2 checks passed
@Akkadius Akkadius deleted the akkadius/rss-portal-fix branch May 16, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joligario joligario joligario approved these changes

@fryguy503 fryguy503 Awaiting requested review from fryguy503

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akkadius @joligario
0