8000 explosive kills not display properly on killfeed by QuentinGruber · Pull Request #2647 · QuentinGruber/h1z1-server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

explosive kills not display properly on killfeed #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 06-28-updt_deps
Choose a base branch
from
Open

explosive kills not display properly on killfeed #2647

wants to merge 1 commit into from

Conversation

QuentinGruber
Copy link
Owner
@QuentinGruber QuentinGruber commented Jun 28, 2025 •
edited
Loading

TL;DR

Fixed kill feed attribution for projectile kills.

What changed?

  • Modified the sendKillFeed method to properly handle projectile kills by checking if the killing entity is a ProjectileEntity
  • When a projectile kills a player, the kill is now attributed to the character who threw/fired the projectile instead of the projectile itself
  • Added _throwableProjectiles to the entity lookup in the getEntity method to ensure projectiles can be properly identified

How to test?

  1. Join a game with at least two players
  2. Use a projectile weapon (grenade, rocket launcher, etc.) to kill another player
  3. Verify that the kill feed correctly shows your character as the killer, not the projectile

Why make this change?

Previously, when a player was killed by a projectile, the kill feed would incorrectly attribute the kill to the projectile entity rather than the player who threw/fired it. This change ensures proper kill attribution in the kill feed, improving the player experience and game statistics tracking.

@QuentinGruber Graphite App
Copy link
Owner Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 28, 2025
Open
Open
Open
Open
@github-actions github-actions bot added the client-2016 About the 2016 client label Jun 28, 2025
@QuentinGruber QuentinGruber marked this pull request as ready for review June 28, 2025 17:46
@QuentinGruber QuentinGruber linked an issue Jun 28, 2025 that may be closed by this pull request
Players killed by grenades Kill notifications fail to play correctly #2360
Open
@QuentinGruber QuentinGruber force-pushed the 06-28-explosive_kills_not_display_properly_on_killfeed branch from 8c50b8a to 937beef Compare June 28, 2025 17:51
@QuentinGruber QuentinGruber added this to the 0.45.9 milestone Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client-2016 About the 2016 client
Projects
None yet
Milestone
0.46.0
Development

Successfully merging this pull request may close these issues.

Players killed by grenades Kill notifications fail to play correctly
1 participant
@QuentinGruber
0