8000 fix issue 693, Fail compiling Quick using Carthage because of SwiftLint by nerd0geek1 · Pull Request #694 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix issue 693, Fail compiling Quick using Carthage because of SwiftLint #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2017

Conversation

nerd0geek1
Copy link
Contributor

close #693

What behavior was changed?

  • SwiftLint will be execute only in Test(It isn't executed in Build).

What I did

  • delete SwiftLint Run Script Phase from Quick-macOS/Quick-iOS/Quick-tvOS target.
  • add Aggregate to execute SwiftLint Run Script

The reason why I submit this PR is written on #693, so please refer it.

@QuickBot
Copy link
1 Warning
⚠️ Big PR

Generated by 🚫 danger

@wongzigii
Copy link
Member

Thanks for this! 👍

@jeffh jeffh merged commit 101f944 into Quick:master Mar 7, 2017
@jeffh
Copy link
Member
jeffh commented Mar 7, 2017

Thanks @nerd0geek1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail compiling Quick using Carthage because of SwiftLint
4 participants
0