8000 Cache the included example count on Example.run() by dbarden · Pull Request #697 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cache the included example count on Example.run() #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2017
Merged

Cache the included example count on Example.run() #697

merged 1 commit into from
Mar 7, 2017

Conversation

dbarden
Copy link
Contributor
@dbarden dbarden commented Mar 3, 2017

Due to the fact that world.includedExamples is a computed property that does a filter on all the tests, performing numberOfExamplesRun >= world.includedExampleCount is not very efficient
with a very large number of tests.

This patch caches the result of world.includedExampleCount and uses the cached value to perform the comparison.

Fix #696

@dbarden 8000
Cache the included example count on Example.run()
c5b5cfd 
Due to the fact that world.includedExamples is a computed property that
does  a filter on all the tests, performing
`numberOfExamplesRun >= world.includedExampleCount` is not very efficient
with a very large number of tests.

This patch caches the result of world.includedExampleCount and uses the
cached value to perform the comparison.

Fix #696
@QuickBot
Copy link
QuickBot commented Mar 3, 2017
1 Warning
⚠️ Need to add an unit test if you’re modifying swift source

Generated by 🚫 danger

@jeffh jeffh merged commit fddfaa3 into Quick:master Mar 7, 2017
@jeffh
Copy link
Member
jeffh commented Mar 7, 2017

Thanks @dbarden!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.
3 participants
@dbarden @QuickBot @jeffh
0