Create Ubuntu docker image without build dependencies #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! |
Merged
|
The commit has been merge with #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a multi-stage build for the docker image based on
ubuntu:latest. The final image will both contain the DEB package and have it installed. After this change, all the build dependencies will be removed and the final image will be considerably smaller (1 GB -> 500 MB), but still be able to run QBDI. To reduce the size of the image even more, see #55.This change should be completely compatible with the existing scripts. The only important change is the use of the
latesttag for the Ubuntu image instead of the17.10tag. The build on the new version has been tested and works as expected.