Update minimum Rust version to 1.64 #10541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5738113329
💛 - Coveralls |
Raising the minimum Rust version lets us access workspace dependencies,
which are a convenient way of managing shared metadata between the
different crates in the project, which deduplicates a good amount of
our metadata. This also lets us share the PyO3 version and minimum
feature set between crates, reducing the number of places that need to
be updated on a Python version bump.
`Cargo.lock` is completely regenerated for this commit with the new
unification, with the minor tweak of having run
cargo update -p 'indexmap@2.0.0' --precise '1.9.3'
This is required to unify the `hashbrown` versions down to 0.12.3
between our dependencies and `pyo3`, which otherwise transitively
depends on `hashbrown ^0.14` via pulling in `indexmap 2.0`. This caused
a build failure, since the `hashbrown` types that PyO3 adds `impl`s of
its traits to are not the same types that our extension modules attempt
to use with it.
SameerD-phys
pushed a commit
to SameerD-phys/qiskit-terra
that referenced
this pull request
Sep 7, 2023
Raising the minimum Rust version lets us access workspace dependencies,
which are a convenient way of managing shared metadata between the
different crates in the project, which deduplicates a good amount of
our metadata. This also lets us share the PyO3 version and minimum
feature set between crates, reducing the number of places that need to
be updated on a Python version bump.
`Cargo.lock` is completely regenerated for this commit with the new
unification, with the minor tweak of having run
cargo update -p 'indexmap@2.0.0' --precise '1.9.3'
This is required to unify the `hashbrown` versions down to 0.12.3
between our dependencies and `pyo3`, which otherwise transitively
depends on `hashbrown ^0.14` via pulling in `indexmap 2.0`. This caused
a build failure, since the `hashbrown` types that PyO3 adds `impl`s of
its traits to are not the same types that our extension modules attempt
to use with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Raising the minimum Rust version lets us access workspace dependencies, which are a convenient way of managing shared metadata between the different crates in the project, which deduplicates a good amount of our metadata. This also lets us share the PyO3 version and minimum feature set between crates, reducing the number of places that need to be updated on a Python version bump.
Cargo.lockis completely regenerated for this commit with the new unification, with the minor tweak of having runThis is required to unify the
hashbrownversions down to 0.12.3 between our dependencies andpyo3, which otherwise transitively depends onhashbrown ^0.14via pulling inindexmap 2.0. This caused a build failure, since thehashbrowntypes that PyO3 addsimpls of its traits to are not the same types that our extension modules attempt to use with it.Details and comments
This bump also means that
rust-analyzeris available as a toolchain component in the default Rust version for the project, which is a nice convenience for those who plug it into their editors (me).