-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Bump MSRV to 1.79 #13709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.79 #13709
Conversation
This commit bumps the minimum supported rust version (MSRV) from 1.70 to 1.79. The newer rust version lets us leverage new language features in Qiskit's rust code which will be increasingly important as we use more rust inside of Qiskit. This commit raises the MSRV proactively to align with the 2.0.0 release so we don't have to potentially raise it during a minor version release (like 2.1.0 or 2.2.0) if we start using these language features later.
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 12892767836Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of inline questions about packages that got added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for doing this.
* Bump MSRV to 1.79 This commit bumps the minimum supported rust version (MSRV) from 1.70 to 1.79. The newer rust version lets us leverage new language features in Qiskit's rust code which will be increasingly important as we use more rust inside of Qiskit. This commit raises the MSRV proactively to align with the 2.0.0 release so we don't have to potentially raise it during a minor version release (like 2.1.0 or 2.2.0) if we start using these language features later. * Fix 1.79 clippy warning
Summary
This commit bumps the minimum supported rust version (MSRV) from 1.70 to 1.79. The newer rust version lets us leverage new language features in Qiskit's rust code which will be increasingly important as we use more rust inside of Qiskit. This commit raises the MSRV proactively to align with the 2.0.0 release so we don't have to potentially raise it during a minor version release (like 2.1.0 or 2.2.0) if we start using these language features later.
Details and comments