8000 Bump MSRV to 1.79 by mtreinish · Pull Request #13709 · Qiskit/qiskit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump MSRV to 1.79 #13709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Bump MSRV to 1.79 #13709

merged 2 commits into from
Jan 21, 2025

Conversation

mtreinish
Copy link
Member

Summary

This commit bumps the minimum supported rust version (MSRV) from 1.70 to 1.79. The newer rust version lets us leverage new language features in Qiskit's rust code which will be increasingly important as we use more rust inside of Qiskit. This commit raises the MSRV proactively to align with the 2.0.0 release so we don't have to potentially raise it during a minor version release (like 2.1.0 or 2.2.0) if we start using these language features later.

Details and comments

This commit bumps the minimum supported rust version (MSRV) from 1.70 to
1.79. The newer rust version lets us leverage new language features in
Qiskit's rust code which will be increasingly important as we use more
rust inside of Qiskit. This commit raises the MSRV proactively to align
with the 2.0.0 release so we don't have to potentially raise it during a
minor version release (like 2.1.0 or 2.2.0) if we start using these
language features later.
@mtreinish mtreinish added Changelog: API Change Include in the "Changed" section of the changelog Rust This PR or issue is related to Rust code in the repository labels Jan 21, 2025
@mtreinish mtreinish added this to the 2.0.0 milestone Jan 21, 2025
@mtreinish mtreinish requested a review from a team as a code owner January 21, 2025 17:13
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link
coveralls commented Jan 21, 2025

Pull Request Test Coverage Report for Build 12892767836

Details

  • 45 of 46 (97.83%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.008%) to 88.935%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/accelerate/src/basis/basis_translator/basis_search.rs 45 46 97.83%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 92.06%
crates/qasm2/src/lex.rs 2 92.98%
Totals Coverage Status
Change from base Build 12891072018: 0.008%
Covered Lines: 79468
Relevant Lines: 89355

💛 - Coveralls

Copy link
Contributor
@raynelfss raynelfss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of inline questions about packages that got added.

Copy link
Contributor
@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing this.

@kevinhartman kevinhartman added this pull request to the merge queue Jan 21, 2025
Merged via the queue into Qiskit:main with commit e2eb611 Jan 21, 2025
17 checks passed
@mtreinish mtreinish deleted the bump-msrv-to-179 branch January 21, 2025 21:04
emilkovacev pushed a commit to emilkovacev/qiskit that referenced this pull request Feb 7, 2025
* Bump MSRV to 1.79

This commit bumps the minimum supported rust version (MSRV) from 1.70 to
1.79. The newer rust version lets us leverage new language features in
Qiskit's rust code which will be increasingly important as we use more
rust inside of Qiskit. This commit raises the MSRV proactively to align
with the 2.0.0 release so we don't have to potentially raise it during a
minor version release (like 2.1.0 or 2.2.0) if we start using these
language features later.

* Fix 1.79 clippy warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: API Change Include in the "Changed" section of the changelog Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0