New methods in ObservablesArray: sparse_observables_array and sparse_observables_array_slice
#14344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
|
One or more of the following people are relevant to this code:
|
ihincks
reviewed
May 11, 2025
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
ObservablesArray: get_sparse_observable and sparse_observables_arrayObservablesArray: sparse_observables_array and sparse_observables_array_slice
ihincks
previously approved these changes
May 12, 2025
ihincks
reviewed
May 20, 2025
| obs = self.copy() if copy else self | ||
| return obs._array | ||
|
|
||
| IndexType = Union[int, slice, None] # pylint: disable=used-before-assignment |
There was a problem hiding this comment.
This is currently in the namespace of the ObservablesArray (as ObservablesArray.IndexType). I would move it to the module.
There was a problem hiding this comment.
What do you mean by moving it to the class?
There was a problem hiding this comment.
Sorry that was a typo, fixed. I mean moving it out of the class, into the module.
ihincks
approved these changes
May 20, 2025
velocityraptor7085
pushed a commit
to velocityraptor7085/qiskit
that referenced
this pull request
May 22, 2025
…arse_observables_array_slice` (Qiskit#14344) * added SparseObservable to ObservableLike * wrote apply_layout * wrote test_equivalent * more layout tests * black * lint * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * create the zero observable outside of a loop * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * don't import unused List * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * setting validate=False in a reliable creation of an ObervablesArray object * black * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * fixing doc string * defer apply_layout checks to SparseObservable * lint * wrote get_sparse_observable * wrote sparse_observables_array * typo * removed Ellipsis type because of CI failure * release notes * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update releasenotes/notes/observables-array-7d7544b3bb3fbaa3.yaml Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update releasenotes/notes/observables-array-7d7544b3bb3fbaa3.yaml Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * renamed function * black * fixes * shorten method name to 'slice' * disable an erroneous lint error * moving IndexType outside of obs-array class --------- Co-authored-by: Ian Hincks <ian.hincks@gmail.com> Co-authored-by: Ian Hincks <ian.hincks@ibm.com>
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
…arse_observables_array_slice` (Qiskit#14344) * added SparseObservable to ObservableLike * wrote apply_layout * wrote test_equivalent * more layout tests * black * lint * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * create the zero observable outside of a loop * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * don't import unused List * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * setting validate=False in a reliable creation of an ObervablesArray object * black * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * fixing doc string * defer apply_layout checks to SparseObservable * lint * wrote get_sparse_observable * wrote sparse_observables_array * typo * removed Ellipsis type because of CI failure * release notes * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update qiskit/primitives/containers/observables_array.py Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update releasenotes/notes/observables-array-7d7544b3bb3fbaa3.yaml Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * Update releasenotes/notes/observables-array-7d7544b3bb3fbaa3.yaml Co-authored-by: Ian Hincks <ian.hincks@gmail.com> * renamed function * black * fixes * shorten method name to 'slice' * disable an erroneous lint error * moving IndexType outside of obs-array class --------- Co-authored-by: Ian Hincks <ian.hincks@gmail.com> Co-authored-by: Ian Hincks <ian.hincks@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the last PR for completion of #14129.
Details and comments
In addition to the new methods, I changed the type hints of
__getitem__and enhanced its tests. The type hints are still not fully accurate, since they don't covertuple[()](as inarr[()]), but I don't want to make them more cumbersome.