Add C API function to add a delay #14347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 14981318567Details
💛 - Coveralls |
kt474
commented
May 12, 2025
Cryoris
reviewed
May 12, 2025
Cryoris
reviewed
May 12, 2025
| let circuit = unsafe { mut_ptr_as_ref(circuit) }; | ||
|
|
||
| let delay_unit_variant = match unit { | ||
| QkDelayUnit::S => DelayUnit::S, |
There was a problem hiding this comment.
We typically don't add the Qk prefix to the structs manually (see e.g. SparseTerm or OpCounts in the cext crate), and have cbindgen add this prefix. It would be more consistent to do the same here, but I'm not super set on this 🙂
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Cryoris
approved these changes
May 13, 2025
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
* add delay c api function * add test * update test * lint * address comments * Update crates/cext/src/circuit.rs Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update crates/cext/src/circuit.rs Co-authored-by: Julien Gacon <gaconju@gmail.com> * add return doc --------- Co-authored-by: Julien Gacon <gaconju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #14237
Details and comments