Fix alignment checks of stretch variables (backport #14330)
#14331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix alignment checks of `stretch` variables We treat `stretch` as meaning that a lower-level compiler will be rescheduling to resolve the stretch, so we don't need to worry about the alignment ourselves. * Use non-retired backend as an example (cherry picked from commit bf828a7)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
jakelishman
previously approved these changes
May 8, 2025
Merged
Pull Request Test Coverage Report for Build 14928080482Details
💛 - Coveralls |
mtreinish
approved these changes
May 9, 2025
Comment on lines
+2362
to
+2363
| # No meaningful assertions; this is a simple regression test for "stretches don't explode | ||
| # backends with alignments" more than anything. |
There was a problem hiding this comment.
I would have added an assertion that a QuantumCircuit was returned but this is just a backport so it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We treat
stretchas meaning that a lower-level compiler will be rescheduling to resolve the stretch, so we don't need to worry about the alignment ourselves.Summary
Details and comments
Fix #14264
This is an automatic backport of pull request #14330 done by Mergify.