Avoid using rustworkx 0.16.0 methods in vf2_utils #14513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
In Qiskit#14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see Qiskit#14507) to rustworkx 0.16.0 using this method isn't strictly necessary and Qiskit#14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement.
|
@Mergifyio backport stable/1.4 stable/2.0 |
✅ Backports have been created
|
Pull Request Test Coverage Report for Build 15395190072Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jakelishman
reviewed
Jun 2, 2025
|
Running the tests on Do you get the same? |
|
That test failure is unrelated - it's something to do with your graphviz installation. |
|
It was because I was testing on rustworkx 0.15.0 -- not 0.15.1 😅 |
<
8000
/tr>
Cryoris
approved these changes
Jun 4, 2025
There isn't a hard rule we take it on a case by case basis. I'd say in this particular case the test was for visualization functions and doesn't justify a minimum version bump because most users will never see that bug. If it was something like the coupling map didn't work at all then yeah we'd bump the minimum |
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors (cherry picked from commit 9aa1a29)
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors (cherry picked from commit 9aa1a29)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…14533) * Avoid using rustworkx 0.16.0 methods in vf2_utils (#14513) * Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors (cherry picked from commit 9aa1a29) * Add release note --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…14534) * Avoid using rustworkx 0.16.0 methods in vf2_utils (#14513) * Avoid using rustworkx 0.16.0 methods in vf2_utils In #14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors (cherry picked from commit 9aa1a29) * Add release note --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
rahaman-quantum
pushed a commit
to rahaman-quantum/qiskit
that referenced
this pull request
Jun 20, 2025
* Avoid using rustworkx 0.16.0 methods in vf2_utils In Qiskit#14218 the vf2_utils module was updated to use the `PyDiGraph.neighbors_undirected()` method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see Qiskit#14507) to rustworkx 0.16.0 using this method isn't strictly necessary and Qiskit#14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0. This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement. * Correctly handle duplicates across successors and predecessors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #14218 the vf2_utils module was updated to use the
PyDiGraph.neighbors_undirected()method which was added in 0.16.0. However that PR neglected to bump the minimum required version of rustworkx to 0.16.0 from 0.15.0 which is the current minim version listed. While we could bump the minimum version (see #14507) to rustworkx 0.16.0 using this method isn't strictly necessary and #14218 was backported to stable branches and backporting a version bump is not desireable. This commit instead just updates the rustworkx usage to use APIs in 0.15.0.This PR will need to be backported to stable/1.4 and stable/2.0 to fix compatibility with the listed rustworkx requirement. However, in the backport a fix note will be needed to document that the release fixes compatibility with the listed requirement.
Details and comments