[POC] Reconsider associatedProperty(), associatedObject(), rex_valueProperty() interfaces #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperty() interfaces This change enables to pass the host (receiver) instance to `initial` and `setter` closures. Thus the caller of the functions don't need to use weak-captured host instance to implement the closures. `NSObjectType` protocol and `rex_valueProperty()` which is basend on its `InstanceType` typealias might seem tricky. We can remove the trick if needed with the way as `UIBarItem.rex_enabled` is implemented (direct use of `associatedProperty()`).
|
Awesome! I'm all for making it even easier and less error prone to expose additional properties. |
| @@ -55,10 +55,16 @@ public func associatedProperty<T: AnyObject>(host: AnyObject, keyPath: StaticStr | |||
| /// | |||
| /// N.B. Ensure that `host` isn't strongly captured by `initial` or `setter`, otherwise this | |||
| /// will create a retain cycle with `host` causing it to never dealloc. | |||
There was a problem hiding this comment.
This comment and the ones like it below can all be removed now since you've isolated the problem and caller's don't need to worry about it.
I leave the comment for |
|
Lets leave that one as-is. |
neilpa
added a commit
that referenced
this pull request
Nov 25, 2015
Reconsider associatedProperty(), associatedObject(), rex_valueProperty() interfaces
|
🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables to pass the host (receiver) instance to
initialandsetterclosures. Thus the caller of the functions don't need to use weak-captured host instance to implement the closures.NSObjectTypeprotocol andrex_valueProperty()which is based on itsInstanceTypetypealias might seem tricky. We can remove the trick if needed with the way asUIBarItem.rex_enabledis implemented (direct use ofassociatedProperty()).