8000 ReactiveCocoa 4.0 support by mbuchetics · Pull Request #83 · RACCommunity/Rex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ReactiveCocoa 4.0 support #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
github "antitypical/Result" "1.0.1"
github "ReactiveCocoa/ReactiveCocoa" "v4.0.0"
github "antitypical/Result" "1.0.2"
github "ReactiveCocoa/ReactiveCocoa" "v4.0.1"
6 changes: 3 additions & 3 deletions Rex.podspec
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Pod::Spec.new do |s|
s.name = 'Rex'
s.module_name = 'Rex'
s.version = '0.9.0-RC.2'
s.version = '0.9.0'
s.summary = 'ReactiveCocoa Extensions'

s.description = <<-DESC
Expand All @@ -18,8 +18,8 @@ Pod::Spec.new do |s|
s.watchos.deployment_target = '2.0'
s.tvos.deployment_target = '9.0'

s.source = { :git => 'https://github.com/neilpa/Rex.git', :tag => '0.9.0-RC.2' }
s.dependency 'ReactiveCocoa', '4.0.0-RC.2'
s.source = { :git => 'https://github.com/neilpa/Rex.git', :tag => '0.9.0' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you see into the future when @neilpa makes the actual tag? But on a serious note, could you so I can push a new spec to trunk? 👯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh. I started a new release right after I merged this https://github.com/neilpa/Rex/releases/tag/0.9.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's been a long time since I updated a podspec and the process has changed quite a bit. I'll try and get it pushed today though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 I just realized the other dependencies have no updated their specs either. But thanks for being so super quick. 👏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you can push this new spec too since you're marked as the maintainer in cocoapods.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but the spec fails linting due to Result not being updated. So in either case we have to wait for the spec of Result 1.0.2 to be pushed.

s.dependency 'ReactiveCocoa', '~> 4.0'
s.ios.framework = 'UIKit'
s.osx.framework = 'AppKit'

Expand Down
1 change: 1 addition & 0 deletions Source/Action.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

import ReactiveCocoa
import enum Result.NoError

extension Action {
/// Creates an always disabled action.
Expand Down
1 change: 1 addition & 0 deletions Source/AppKit/NSTextField.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import Foundation
import ReactiveCocoa
import AppKit
import enum Result.NoError

extension NSTextField {
57A6 /// Sends the field's string value whenever it changes.
Expand Down
1 change: 1 addition & 0 deletions Source/Foundation/NSObject.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import Foundation
import ReactiveCocoa
import enum Result.NoError

extension NSObject {
/// Creates a strongly-typed producer to monitor `keyPath` via KVO. The caller
Expand Down
1 change: 1 addition & 0 deletions Source/Foundation/NSUserDefaults.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import Foundation
import ReactiveCocoa
import enum Result.NoError

extension NSUserDefaults {
/// Sends value of `key` whenever it changes. Attempts to filter out repeats
Expand Down
1 change: 1 addition & 0 deletions Source/Property.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

import ReactiveCocoa
import enum Result.NoError

extension PropertyType where Value == Bool {
/// The conjunction of `self` and `other`.
Expand Down
1 change: 1 addition & 0 deletions Source/Signal.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

import ReactiveCocoa
import enum Result.NoError

extension SignalType {

Expand Down
1 change: 1 addition & 0 deletions Source/SignalProducer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

import ReactiveCocoa
import enum Result.NoError

extension SignalProducerType {

Expand Down
1 change: 1 addition & 0 deletions Source/UIKit/UIControl.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import ReactiveCocoa
import UIKit
import enum Result.NoError

extension UIControl {
#if os(iOS)
Expand Down
1 change: 1 addition & 0 deletions Source/UIKit/UITextField.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import Foundation
import ReactiveCocoa
import UIKit
import enum Result.NoError

extension UITextField {

Expand Down
1 change: 1 addition & 0 deletions Tests/PropertyTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
@testable import Rex
import ReactiveCocoa
import XCTest
import enum Result.NoError

final class PropertyTests: XCTestCase {

Expand Down
1 change: 1 addition & 0 deletions Tests/SignalProducerTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import Rex
import ReactiveCocoa
import XCTest
import enum Result.NoError

final class SignalProducerTests: XCTestCase {

Expand Down
1 change: 1 addition & 0 deletions Tests/SignalTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import Rex
import ReactiveCocoa
import XCTest
import enum Result.NoError

final class SignalTests: XCTestCase {

Expand Down
1 change: 1 addition & 0 deletions Tests/UIKit/UIBarButtonItemTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import ReactiveCocoa
import UIKit
import XCTest
import enum Result.NoError

class UIBarButtonItemTests: XCTestCase {

Expand Down
1 change: 1 addition & 0 deletions Tests/UIKit/UIButtonTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import ReactiveCocoa
import UIKit
import XCTest
import enum Result.NoError

extension UIButton {
static func button() -> UIButton {
Expand Down
1 change: 1 addition & 0 deletions Tests/UIKit/UIControlTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import ReactiveCocoa
import UIKit
import XCTest
import enum Result.NoError

class UIControlTests: XCTestCase {

Expand Down
1 change: 1 addition & 0 deletions Tests/UIKit/UIImageViewTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import ReactiveCocoa
import UIKit
import XCTest
import enum Result.NoError

class UIImageViewTests: XCTestCase {

Expand Down
1 change: 1 addition & 0 deletions Tests/UIKit/UILabelTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import ReactiveCocoa
import UIKit
import XCTest
import enum Result.NoError

class UILabelTests: XCTestCase {

Expand Down
1 change: 1 addition & 0 deletions Tests/UIKit/UIViewTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import ReactiveCocoa
import UIKit
import XCTest
import enum Result.NoError

class UIViewTests: XCTestCase {

Expand Down
0