refactor/viewdock/show-hide-models #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "Show all" and "Hide all" buttons as part of refactor to make table row selection control visibility.
Purpose: refactoring the viewdock tool to use table selection for model display. - remove the "Show" column from the viewdock tool - remove the "MODEL_DISPLAY_CHANGED" trigger handler which was associated with the "Show" col.
Purpose: refactoring the viewdock tool to use table selection for model display. - add table_selection_changed function between the table callback an updating the model description - table_selection_changed function can handle model display adjustment
Purpose: refactoring the viewdock tool to use table selection for model display. - new method update_structure_displays which accpets structures to display and hides all other docking structures. - table_selection_changed method calls update_structure displays.
Hide the show/hide commands from the log when the ViewDock tool changes selection. Table gets scrolled a lot and this change prevents the log from getting cluttered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Docking Model Visibility Via Table Row Selection
Refactor the ViewDock tool to simplify model visibility control via table row selection. This change removes the need for dedicated "Show All", "Hide All", and "Show" column UI elements.
Changes
Removed:
MODEL_DISPLAY_CHANGEDtrigger handler (no longer necessary)Refactored:
table_selection_changedmethod added to respond to selection changesupdate_structure_displaysupdates visibility of selected/unselected modelsImproved:
run()calls for show/hide commands are now made withlog=Falseto prevent log clutter from frequent selection changes