apLCMS: input collections #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xtrojak with execution failing outside of tests you mean with |
Actually it works fine, it was my bad. |
|
I think it is fine to only pass collections - I mean you can pass a collection with a single file, which is fine. |
hechth
approved these changes
Jun 16, 2022
martenson
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the input collections was implemented incorrectly, which made it impossible to use the
apLCMSsteps in workflows. The new implementation in this PR should enable this.Note that from now on, only collections can be passed as an input to the tools (not possible to pass separate files as inputs
).
Close #268