8000 gnrc_pktbuf_static.c: fix overflow in gnrc_pktbuf_realloc_data by cgundogan · Pull Request #4617 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

gnrc_pktbuf_static.c: fix overflow in gnrc_pktbuf_realloc_data #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2016
Merged

gnrc_pktbuf_static.c: fix overflow in gnrc_pktbuf_realloc_data #4617

merged 2 commits into from
Jan 8, 2016

Conversation

cgundogan
Copy link
Member

backport of #4602

jfischer-no and others added 2 commits January 7, 2016 19:35
@jfischer-no @cgundogan
gnrc_pktbuf_static.c: fix overflow in gnrc_pktbuf_realloc_data
b17a870 
This patch fixes overflow, which is caused by
(pkt->size - aligned_size). This happens if pkt->size and
new size are unaligned and the difference
between pkt->size and new size is less than four.
@miri64 @cgundogan
unittests: add unittests for overflow fix
911d79a
@cgundogan cgundogan added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 7, 2016
@cgundogan cgundogan added this to the Release 2015.12 milestone Jan 7, 2016
@miri64
Copy link
Member
miri64 commented Jan 7, 2016

ACK and go, when Travis is green.

miri64 added a commit that referenced this pull request Jan 8, 2016
@miri64
Merge pull request #4617 from cgundogan/pr/pktbuf/fix
f8be047 
gnrc_pktbuf_static.c: fix overflow in gnrc_pktbuf_realloc_data
@miri64 miri64 merged commit f8be047 into RIOT-OS:2015.12-branch Jan 8, 2016
@cgundogan cgundogan deleted the pr/pktbuf/fix branch January 8, 2016 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miri64 miri64

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2015.12
Development

Successfully merging this pull request may close these issues.
3 participants
@cgundogan @miri64 @jfischer-no
0