8000 hashes: support unaligned memory access in be32enc_vect by wentaoshang · Pull Request #5703 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

hashes: support unaligned memory access in be32enc_vect #5703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2016
Merged

hashes: support unaligned memory access in be32enc_vect #5703

merged 1 commit into from
Aug 2, 2016

Conversation

wentaoshang
Copy link
Contributor

This patch allows be32enc_vect to be executed on any memory location, including unaligned memory. If the memory is 4-byte aligned, it will access the data using a pointer of type uint32_t*; otherwise it will access each byte of the data separately and therefore prevents hardware fault on ARM-based CPUs.

See more description in #5102

@BytesGalore BytesGalore added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 28, 2016
@BytesGalore
Copy link
Member

ACK from my side.
But, I would like to hear if @Kijewski also agrees

@BytesGalore BytesGalore self-assigned this Jul 28, 2016
@OlegHahm OlegHahm mentioned this pull request Jul 31, 2016
Closed
@kYc0o
Copy link
Contributor
kYc0o commented Aug 1, 2016

@wentaoshang can you fix the Murdock errors? they're mostly tabs and spaces in your code.

@kYc0o kYc0o added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Aug 1, 2016
@kYc0o kYc0o added this to the Release 2016.07 milestone Aug 1, 2016
@wentaoshang
Copy link
Contributor Author

Just updated the patch. But something's wrong with the docker container...

@BytesGalore BytesGalore added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 1, 2016
@BytesGalore
Copy link
Member

The docker fail is obviously unrelated, what I read from the output [1] is that probably the system has not been installed correctly in the container.
@kYc0o any hints?

[1] https://ci.riot-labs.de/RIOT-OS/RIOT/5703/600c8f626d8cc802c372d2ad6d435bdd10d11f6a/output.html

@kYc0o
Copy link
Contributor
kYc0o commented Aug 1, 2016

Apparently the server is down... @kaspar030 everything is ok?

@kYc0o kYc0o added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 2, 2016
@BytesGalore BytesGalore added CI: 8000 ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 2, 2016
@kaspar030
Copy link
Contributor

@kaspar030 everything is ok?

Seems like the upstream server was down. Seems like it's working again. ;)

@kYc0o
Copy link
Contributor
kYc0o commented Aug 2, 2016

Ok nice, this was actually a bug so let's merge it.

@kYc0o
Copy link
Contributor
kYc0o commented Aug 2, 2016

Already ACKed and Murdock's green so go!

@kYc0o kYc0o merged commit ac4cc08 into RIOT-OS:master Aug 2, 2016
@miri64 miri64 added this to the Release 2016.10 milestone Oct 14, 2016
@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BytesGalore BytesGalore

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2016.10
Development

Successfully merging this pull request may close these issues.
5 participants
@wentaoshang @BytesGalore @kYc0o @kaspar030 @miri64
0