8000 tests: add test for the aconno board acd52832 · Pull Request #7653 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tests: add test for the aconno board acd52832 #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

tests: add test for the aconno board acd52832 #7653

wants to merge 1 commit into from

Conversation

ghost
Copy link
@ghost ghost commented Sep 28, 2017

This PR includes the test for the aconno board ACD52832.

Following features are integrated:

  • Toggle of LED LD2 (over MCP23017)
  • Joystick control S4 (over MCP23017)

And following PRs are required:

@smlng
Copy link
Member
smlng commented Sep 28, 2017

sorry but IMHO board specific tests are a bit against the general concept here. You should rather add a test for your mcp27017 driver instead - looks like you could start by renaming this one and maybe adapt 1 or 2 things ....

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework Discussion: contested The item of discussion was contested labels Sep 28, 2017
@ghost
Copy link
Author
ghost commented Sep 28, 2017

The idea was to expand this test later with features like the electronic paper display.
@smlng What do you think about?

@smlng
Copy link
Member
smlng commented Sep 28, 2017

still not convinced - as said: this would be against the current concept of having board independent tests. The mcp27013 or the e-paper display could be attached to any board (in theory). So there should rather be tests for these devices, first.

Nevertheless, I do see the merits of having board specific tests that check all the peripheral devices attached to a board at once. But that would be an extension of the current test framework, and definitely needs to be discussed in a broader scope -> maybe write an email to devel/maintainer mailing list.

@smlng
Copy link
Member
smlng commented Sep 28, 2017

I guess at least @kaspar030 and @miri64 might have an opinion on that, too.

We could also think about having a separate repo for such tests?

@kaspar030
Copy link
Contributor

this would be against the current concept of having board independent tests. The mcp27013 or the e-paper display could be attached to any board (in theory). So there should rather be tests for these devices, first.

Agreed. If the tests are not dependent on each other (e.g., a motor can only be controlled through a joystick, thus a test application for it would need to include the joystick "test"), they should be in separate, board-independent test applications.

@miri64 miri64 requested a review from kaspar030 October 4, 2017 14:24
@kYc0o kYc0o mentioned this pull request Oct 30, 2017
11 tasks
@PeterKietzmann
Copy link
Member

As agreed offline we close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework Discussion: contested The item of discussion was contested Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0